[radio] use new implementation of time sync #876
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1220,8 +1216,6 @@ int8_t otPlatRadioGetReceiveSensitivity(otInstance *aInstance) | |||
| #if OPENTHREAD_CONFIG_MAC_HEADER_IE_SUPPORT | |||
| void nrf_802154_tx_started(const uint8_t *aFrame) | |||
| { | |||
There was a problem hiding this comment.
We may consider moving the whole implementation of nrf_802154_tx_started() to SubMac, and SubMac provide a function for radio driver to generate the ACK frame. This could greatly reduce platform radio APIs and the complexity of the otRadioFrame.
There was a problem hiding this comment.
I was considering wrapping all manipulations on SFD in a single callback. We probably shouldn't put it into SubMac, as this callback is probably called by a ISR.
bukepo
force-pushed
the
time-sync-new
branch
from
a8b4e87 to
388aa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.