Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] refine CMake files #52

Merged
merged 8 commits into from
Apr 8, 2020
Merged

[build] refine CMake files #52

merged 8 commits into from
Apr 8, 2020

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Mar 29, 2020 •
edited by jwhui
Loading

This PR refines CMake files

  • avoid setting CMAKE_C_FLAGS and CMAKE_CXX_FLAGS in project root directory.
  • add mbedtls and libevent wrappers to inherit include directories.
  • specify target sources separately and include header files as well.
  • follow openthread/openthread CMake style.

@wgtdkp wgtdkp requested review from bukepo and gjc13 March 29, 2020 10:03
@codecov-io
Copy link

codecov-io commented Mar 29, 2020 •
edited
Loading

Codecov Report

Merging #52 into master will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   60.02%   60.32%   +0.30%     
==========================================
  Files          52       52              
  Lines        5381     5379       -2     
==========================================
+ Hits         3230     3245      +15     
+ Misses       2151     2134      -17
Impacted Files Coverage Δ
src/library/dtls.hpp 66.66% <0.00%> (ø)
src/common/address.cpp 100.00% <0.00%> (ø)
src/library/socket.hpp 75.00% <0.00%> (ø)
src/app/commissioner_app.cpp 29.76% <0.00%> (ø)
src/library/commissioner_impl.cpp 61.90% <0.00%> (ø)
src/library/coap.cpp 71.97% <0.00%> (+0.27%) ⬆️
src/common/utils.hpp 56.52% <0.00%> (+1.97%) ⬆️
src/library/dtls.cpp 82.26% <0.00%> (+5.29%) ⬆️

gocarlos
gocarlos reviewed Apr 7, 2020
View reviewed changes
src/library/CMakeLists.txt Outdated Show resolved Hide resolved
@gocarlos gocarlos mentioned this pull request Apr 7, 2020
Draft
bukepo
bukepo approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

src/library/CMakeLists.txt Outdated Show resolved Hide resolved
gjc13
gjc13 approved these changes Apr 8, 2020
View reviewed changes
third_party/mbedtls/CMakeLists.txt Show resolved Hide resolved
@wgtdkp
Copy link
Member Author

wgtdkp commented Apr 8, 2020

@gocarlos more comments?

gocarlos
gocarlos reviewed Apr 8, 2020
View reviewed changes
src/app/CMakeLists.txt Outdated Show resolved Hide resolved
@wgtdkp wgtdkp closed this Apr 8, 2020
@wgtdkp wgtdkp reopened this Apr 8, 2020
@gocarlos
Copy link
Contributor

gocarlos commented Apr 8, 2020

LGTM 👍

@wgtdkp
Copy link
Member Author

wgtdkp commented Apr 8, 2020 •
edited
Loading

@gocarlos maybe you want to approve this change?

You can click "Files changed", then click "review changes" at right hand side to approve it.

@wgtdkp wgtdkp requested a review from jwhui April 8, 2020 12:21
@jwhui jwhui added the enhancement New feature or request label Apr 8, 2020
@jwhui jwhui merged commit 5807ba8 into openthread:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhui jwhui jwhui approved these changes

@gjc13 gjc13 gjc13 approved these changes

@bukepo bukepo bukepo approved these changes

@gocarlos gocarlos gocarlos approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wgtdkp @codecov-io @gocarlos @bukepo @gjc13 @jwhui