Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] allow using find_package instead of vendored submodules #46

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[build] allow using find_package instead of vendored submodules #46

wants to merge 8 commits into from

Conversation

gocarlos
Copy link
Contributor

@gocarlos gocarlos commented Mar 25, 2020 •
edited
Loading

closes #17

@wgtdkp wgtdkp changed the title [wip] build: allow using find_package instead of vendored submodules [build] allow using find_package instead of vendored submodules Mar 25, 2020
@codecov-io
Copy link

codecov-io commented Mar 27, 2020 •
edited
Loading

Codecov Report

Merging #46 into master will decrease coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   60.32%   59.71%   -0.62%     
==========================================
  Files          52       52              
  Lines        5379     5381       +2     
==========================================
- Hits         3245     3213      -32     
- Misses       2134     2168      +34
Impacted Files Coverage Δ
src/app/cli/main.cpp 51.85% <0.00%> (-22.23%) ⬇️
src/library/cbor.hpp 40.00% <0.00%> (-20.00%) ⬇️
src/app/cli/console.cpp 65.38% <0.00%> (-11.54%) ⬇️
src/library/coap.hpp 83.33% <0.00%> (-10.61%) ⬇️
src/library/dtls.cpp 76.97% <0.00%> (-5.30%) ⬇️
src/common/utils.hpp 54.54% <0.00%> (-1.98%) ⬇️
src/library/coap.cpp 71.70% <0.00%> (-0.28%) ⬇️
src/library/dtls.hpp 66.66% <0.00%> (ø)
src/common/address.cpp 100.00% <0.00%> (ø)
src/library/socket.hpp 75.00% <0.00%> (ø)
... and 2 more

@gocarlos
Copy link
Contributor Author

gocarlos commented Apr 7, 2020

waiting for #52 to land to continue here

@gocarlos
Copy link
Contributor Author

gocarlos commented May 7, 2020

@deimi please take over this

Base automatically changed from master to main March 8, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use the find package in cmake optionally, now only vendored using submodules
3 participants
@gocarlos @codecov-io @wgtdkp