[PD] make PD upstream interface consistent with infra_if name #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
===========================================
- Coverage 55.77% 44.93% -10.84%
===========================================
Files 87 106 +19
Lines 6890 12769 +5879
Branches 0 949 +949
===========================================
+ Hits 3843 5738 +1895
- Misses 3047 6724 +3677
- Partials 0 307 +307 ☔ View full report in Codecov by Sentry. |
Irving-cl
reviewed
Dec 18, 2024
| @@ -30,8 +30,7 @@ | |||
| # This script manipulates DHCPv6-PD-REF configuration. | |||
| # | |||
|
|
|||
| # TODO: set the upstream interface according to the environment variables of `script/setup`. | |||
| UPSTREAM_INTERFACE="eth0" | |||
| UPSTREAM_INTERFACE=${INFRA_IF_NAME} | |||
There was a problem hiding this comment.
As I checked, INFRA_IF_NAME is defined as a environment variable only in dockerfile for harness simulation. That means in other cases this variable will be undefined. Is it correct? Or we need to include other bash script from here?
There was a problem hiding this comment.
You are correct, Li. Thanks for figuring it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.