Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread-host] make AddThreadStateChangedCallback as a ThreadHost API #2587

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds AddThreadStateChangedCallback as a ThreadHost API.

Because this method is also needed under NCP mode. The PR doesn't change the implementation in RcpHost and adds an empty implementation in NcpHost.

Copy link
Contributor

@zesonzhang zesonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.08%. Comparing base (2b41187) to head (3b973dd).
Report is 858 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/ncp_host.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
- Coverage   55.77%   46.08%   -9.69%     
==========================================
  Files          87      104      +17     
  Lines        6890    12504    +5614     
  Branches        0      908     +908     
==========================================
+ Hits         3843     5763    +1920     
- Misses       3047     6428    +3381     
- Partials        0      313     +313     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Irving-cl Irving-cl requested a review from jwhui November 6, 2024 09:19
@jwhui jwhui changed the title [thread host] make AddThreadStateChangedCallback as a ThreadHost API [thread-host] make AddThreadStateChangedCallback as a ThreadHost API Nov 6, 2024
@jwhui jwhui merged commit 7a79c99 into openthread:main Nov 6, 2024
32 checks passed
@Irving-cl Irving-cl deleted the thread_state_changed_callback branch November 21, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants