[trel] updates for switching trel interface #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
- Coverage 55.77% 46.30% -9.48%
==========================================
Files 87 104 +17
Lines 6890 12502 +5612
Branches 0 908 +908
==========================================
+ Hits 3843 5789 +1946
- Misses 3047 6399 +3352
- Partials 0 314 +314 ☔ View full report in Codecov by Sentry. |
sunytt
force-pushed
the
trel-switch-ail
branch
from
82e957b to
ad0634f
Compare
sunytt
force-pushed
the
trel-switch-ail
branch
from
ad0634f to
bd52ffe
Compare
As it's possible to switch network interface for TREL in openthread/openthread#10872, updated trel_dnssd.cpp in 2 places: 1). Initialize() can be called multiple times now, so it should clear the mTrelNetifIndex at the beginning to refresh the index according to the given interface name. 2). HandleMdnsState() may be invoked when TrelDnssd is not initialized, we should still update the mMdnsPublisherReady status, so it's ready to publish a service when TrelDnssd becomes initialized.
sunytt
force-pushed
the
trel-switch-ail
branch
from
bd52ffe to
81139be
Compare
abtink
approved these changes
Nov 5, 2024
jwhui
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's possible to switch network interface for TREL in openthread/openthread#10872, updated trel_dnssd.cpp in 2 places:
1). Initialize() can be called multiple times now, so it should clear the mTrelNetifIndex at the beginning to refresh the index according to the given interface name.
2). HandleMdnsState() may be invoked when TrelDnssd is not initialized, we should still update the mMdnsPublisherReady status, so it's ready to publish a service when TrelDnssd becomes initialized.