-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[application] move ThreadHost::Create out of the Application class #2574
Conversation
7927889
to
472a121
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
- Coverage 55.77% 46.15% -9.63%
==========================================
Files 87 105 +18
Lines 6890 12454 +5564
Branches 0 908 +908
==========================================
+ Hits 3843 5748 +1905
- Misses 3047 6394 +3347
- Partials 0 312 +312 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is after openthread/ot-br-posix#2574 removed the log line we were looking for.
This is after openthread/ot-br-posix#2574 removed the log line we were looking for. Co-authored-by: Andrei Litvin <[email protected]>
This is after openthread/ot-br-posix#2574 removed the log line we were looking for. Co-authored-by: Andrei Litvin <[email protected]>
This is after openthread/ot-br-posix#2574 removed the log line we were looking for. Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
This is after openthread/ot-br-posix#2574 removed the log line we were looking for. Co-authored-by: Andrei Litvin <[email protected]>
This PR refactors the
Application
class.In specific:
Application
withInfraLinkSelector
by movingInfraLinkSelector
out of theApplication
class. The current dependency causes that we cannot move the creation ofThreadHost
instance out of the constructor of theApplication
class.Ncp::ThreadHost::Create
out of theApplication
constructor.This change solves the fuzzer test issue in Android: When we create an
Application
object, we have to initlialize the radio which will cause error in the fuzz environment. With this change, we can pass a FuzzThreadHost object to theApplication
.