Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[border-agent] return invalid args when lifetime exceeds 10min #2567

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[border-agent] return invalid args when lifetime exceeds 10min #2567

merged 1 commit into from
Nov 5, 2024

Conversation

mia1yang
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (2b41187) to head (6a0dda2).
Report is 854 commits behind head on main.

Files with missing lines Patch % Lines
src/dbus/server/dbus_thread_object_rcp.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   55.77%   46.16%   -9.61%     
==========================================
  Files          87      104      +17     
  Lines        6890    12435    +5545     
  Branches        0      905     +905     
==========================================
+ Hits         3843     5741    +1898     
- Misses       3047     6382    +3335     
- Partials        0      312     +312

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sunytt
sunytt approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mia1yang mia1yang marked this pull request as ready for review November 1, 2024 05:39
@librasungirl librasungirl requested a review from jwhui November 1, 2024 05:56
librasungirl
librasungirl reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@librasungirl librasungirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you please also update instropect.xml on ActivateEphemeralKeyMode dbus API for such key information?

@jwhui jwhui merged commit a701edd into openthread:main Nov 5, 2024
32 checks passed
@mia1yang
Copy link
Contributor Author

would you please also update instropect.xml on ActivateEphemeralKeyMode dbus API for such key information?

Modified in RP. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librasungirl librasungirl librasungirl approved these changes

@jwhui jwhui jwhui approved these changes

@sunytt sunytt sunytt approved these changes

Assignees
No one assigned
Labels
comp: border agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mia1yang @sunytt @jwhui @librasungirl @yuzhyang