[thread-host] add set channel max power api #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
thread_host_set_channel_max_power
branch
from
b602940 to
fe42357
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 55.77% 46.13% -9.65%
==========================================
Files 87 104 +17
Lines 6890 12447 +5557
Branches 0 907 +907
==========================================
+ Hits 3843 5742 +1899
- Misses 3047 6394 +3347
- Partials 0 311 +311 ☔ View full report in Codecov by Sentry. |
Irving-cl
force-pushed
the
thread_host_set_channel_max_power
branch
2 times, most recently
from
5159ada to
d7ac367
Compare
Irving-cl
force-pushed
the
thread_host_set_channel_max_power
branch
2 times, most recently
from
11b942d to
345139a
Compare
abtink
approved these changes
Oct 29, 2024
| otbrLogInfo("Set channel max power: channel=%u, maxPower=%d", static_cast<unsigned int>(channel), | ||
| static_cast<int>(maxPower)); | ||
| SuccessOrExit(error = otPlatRadioSetChannelTargetPower(mInstance, channel, maxPower), | ||
| errorMsg = "Failed to set channel max power"); |
There was a problem hiding this comment.
Just noticed that we allow an optional action statement in SuccessOrExit() in ot-br-posix. Nice... :)
Irving-cl
force-pushed
the
thread_host_set_channel_max_power
branch
from
345139a to
ca4146e
Compare
Irving-cl
force-pushed
the
thread_host_set_channel_max_power
branch
from
ca4146e to
104cacd
Compare
jwhui
changed the title
jwhui
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SetChannelMaxPower method to ThreadHost.
The PR implements this method for RcpHost. The implementation for NCP will be added later.