-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[host] add SetThreadEnabled to ThreadHost APIs #2542
[host] add SetThreadEnabled to ThreadHost APIs #2542
Conversation
d903e5f
to
3c236cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
===========================================
- Coverage 55.77% 45.67% -10.10%
===========================================
Files 87 102 +15
Lines 6890 12100 +5210
Branches 0 887 +887
===========================================
+ Hits 3843 5527 +1684
- Misses 3047 6273 +3226
- Partials 0 300 +300 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One smaller suggestion below:
91160b3
to
799c23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
799c23a
to
e58f6e1
Compare
e58f6e1
to
a075af5
Compare
This PR adds a new method
SetThreadEnabled
as a ThreadHost API.The method is added so that the Android binder API can be easily implemented without the need to handle NCP/RCP case. In this PR,
RcpHost::SetThreadEnabled
is impelmented andNcpHost::SetThreadEnabled
will be implemented later.