Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[host] add SetThreadEnabled to ThreadHost APIs #2542

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds a new method SetThreadEnabled as a ThreadHost API.

The method is added so that the Android binder API can be easily implemented without the need to handle NCP/RCP case. In this PR, RcpHost::SetThreadEnabled is impelmented and NcpHost::SetThreadEnabled will be implemented later.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 3.33333% with 29 lines in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (2b41187) to head (a075af5).
Report is 828 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/rcp_host.cpp 4.00% 24 Missing ⚠️
src/ncp/rcp_host.hpp 0.00% 3 Missing ⚠️
src/ncp/ncp_host.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2542       +/-   ##
===========================================
- Coverage   55.77%   45.67%   -10.10%     
===========================================
  Files          87      102       +15     
  Lines        6890    12100     +5210     
  Branches        0      887      +887     
===========================================
+ Hits         3843     5527     +1684     
- Misses       3047     6273     +3226     
- Partials        0      300      +300     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One smaller suggestion below:

src/ncp/rcp_host.cpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the thread_host_set_thread_enabled branch 2 times, most recently from 91160b3 to 799c23a Compare October 16, 2024 03:25
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Irving-cl Irving-cl force-pushed the thread_host_set_thread_enabled branch from 799c23a to e58f6e1 Compare October 16, 2024 10:21
@Irving-cl Irving-cl force-pushed the thread_host_set_thread_enabled branch from e58f6e1 to a075af5 Compare October 16, 2024 11:34
@Irving-cl Irving-cl requested a review from jwhui October 16, 2024 11:54
@jwhui jwhui merged commit 689483c into openthread:main Oct 17, 2024
32 checks passed
@Irving-cl Irving-cl deleted the thread_host_set_thread_enabled branch October 21, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants