Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[application] simplify fdset update #2469

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds methods to MainloopContext to encapsulate the process to add an fd to some fd sets of it and update the maxFd. This simplifies the implementation. Previous discussion for this change.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.56%. Comparing base (2b41187) to head (eadd970).
Report is 788 commits behind head on main.

Files with missing lines Patch % Lines
src/common/mainloop.cpp 66.66% 2 Missing and 3 partials ⚠️
src/dbus/server/dbus_agent.cpp 75.00% 1 Missing ⚠️
src/utils/infra_link_selector.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2469       +/-   ##
===========================================
- Coverage   55.77%   45.56%   -10.22%     
===========================================
  Files          87       99       +12     
  Lines        6890    11663     +4773     
  Branches        0      849      +849     
===========================================
+ Hits         3843     5314     +1471     
- Misses       3047     6072     +3025     
- Partials        0      277      +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :) Thanks @Irving-cl for adding this. 👍 👍

@jwhui jwhui merged commit 9f86725 into openthread:main Sep 3, 2024
32 checks passed
@Irving-cl Irving-cl requested a review from jwhui September 4, 2024 00:34
@Irving-cl Irving-cl deleted the simplify_fd_update branch September 5, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants