[ncp] use SendCommand with no va_args requirement to avoid compilation issues
#2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
===========================================
- Coverage 55.77% 45.37% -10.40%
===========================================
Files 87 99 +12
Lines 6890 11334 +4444
Branches 0 816 +816
===========================================
+ Hits 3843 5143 +1300
- Misses 3047 5936 +2889
- Partials 0 255 +255 ☔ View full report in Codecov by Sentry. |
suveshpratapa
force-pushed
the
bugfix/openthread/ncp_spinel_vargs_issue
branch
from
4627e3c to
81da3c2
Compare
abtink
reviewed
Aug 21, 2024
…ent to avoid compilation issues Avoids an issue in `ncp_spinel.cpp` related to a dummy va_list variable being uninitialized.
suveshpratapa
force-pushed
the
bugfix/openthread/ncp_spinel_vargs_issue
branch
from
81da3c2 to
d91f437
Compare
suveshpratapa
changed the title
ncp_spinel.cppSendCommand with no va_args requirement to avoid compilation issues
suveshpratapa
changed the title
SendCommand with no va_args requirement to avoid compilation issuesSendCommand with no va_args requirement to avoid compilation issues
|
@jwhui Just wanted to bring this to your attention... should be ready to merge. |
jwhui
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in
ncp_spinel.cpprelated to a dummy va_list variable being uninitialized.