[mdns] change PublishService() to get encoded TXT data as input
#1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates `Mdns::Publisher::PublishService()` to take encoded TXT data as its input, harmonizing the `Publish` API with the `Subscribe` API, which also uses encoded TXT data. This makes it easier to use with advertising proxy and TREL, avoiding the extra step of decoding already encoded TXT data to call `PublishService()`.
abtink
force-pushed
the
mdns/publish-use-encoded-txt-data
branch
from
78ba6c1 to
d3314fb
Compare
jwhui
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
Mdns::Publisher::PublishService()to take encoded TXT data as its input, harmonizing thePublishAPI with theSubscribeAPI, which also uses encoded TXT data. This makes it easier to use with advertising proxy and TREL, avoiding the extra step of decoding already encoded TXT data to callPublishService().This PR currently contains the commit from PR [mdns] updateTxtEntryto handle boolean attribute #1992.Please check/review the second commit only.