Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] generic vendor server #1995

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Sep 4, 2023

This PR include two commits:

  1. reverts [android] replace VendorServer with OtDaemonServer #1967 as it breaks community use cases
  2. Make VendorServer more generic to be used by multiple vendors. See [android] replace VendorServer with OtDaemonServer #1967 (comment)

Prefer merging this PR as separate commits

@wgtdkp wgtdkp changed the title Generic vendor server [utils] generic vendor server Sep 4, 2023
…d#1967)" (openthread#1995)

This reverts commit 300cfed.

Change-Id: Ic8694b97ddb4125599314769361ea10d483b01cc
wgtdkp added a commit to wgtdkp/ot-br-posix that referenced this pull request Sep 4, 2023
This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)

Change-Id: Ic322efbee9b58d7a2743c72a511572ec7ebfb262
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from f169587 to 76837f7 Compare September 4, 2023 12:41
wgtdkp added a commit to wgtdkp/ot-br-posix that referenced this pull request Sep 4, 2023
This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)

Change-Id: Ic322efbee9b58d7a2743c72a511572ec7ebfb262
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from 76837f7 to 6a9488b Compare September 4, 2023 12:49
wgtdkp added a commit to wgtdkp/ot-br-posix that referenced this pull request Sep 4, 2023
This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from 6a9488b to 19232c5 Compare September 4, 2023 13:10
wgtdkp added a commit to wgtdkp/ot-br-posix that referenced this pull request Sep 4, 2023
This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from 19232c5 to c0e3774 Compare September 4, 2023 13:29
@DarthBo
Copy link

DarthBo commented Sep 4, 2023

This looks good to me, thanks for considering this!

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wgtdkp added a commit to wgtdkp/ot-br-posix that referenced this pull request Sep 5, 2023
This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from c0e3774 to 666cbcb Compare September 5, 2023 07:00
wgtdkp added a commit to wgtdkp/ot-br-posix that referenced this pull request Sep 5, 2023
This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from 666cbcb to fd72331 Compare September 5, 2023 07:04
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/agent/vendor.hpp Show resolved Hide resolved
@wgtdkp wgtdkp requested a review from jwhui September 5, 2023 07:17
@wgtdkp
Copy link
Member Author

wgtdkp commented Sep 5, 2023

@jwhui prefer merging this PR as separate commits

This commit changes VendorServer to an abstract class so that it
can be extended to have different implementations.

Fulfills request from openthread#1967 (comment)

Change-Id: Ic1b41b8b60e5953142854f761e377e080f1937fc
@wgtdkp wgtdkp force-pushed the generic-vendor-server branch from fd72331 to b38ff23 Compare September 6, 2023 04:07
@jwhui jwhui merged commit 208891f into openthread:main Sep 6, 2023
jwhui pushed a commit that referenced this pull request Sep 6, 2023
…1995)

This reverts commit 300cfed.

Change-Id: Ic8694b97ddb4125599314769361ea10d483b01cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants