[telemetry] define key telemetries and their extraction logic #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morningboata
commented
Aug 17, 2023
morningboata
commented
- Telemetry definition is available in thread_telemetry.proto
- Telemetry extraction logic is provided in thread_helper.cpp
- DBus RPC service is served; thread_helper's Telemetry lib allows to support additional telemetry service integration if needed.
added 20 commits
July 20, 2023 11:30
|
Is this change for Android? |
|
This is for Android and other devices (like router) as well. |
superwhd
reviewed
Aug 24, 2023
superwhd
reviewed
Aug 24, 2023
superwhd
reviewed
Aug 24, 2023
added 2 commits
August 24, 2023 16:48
superwhd
reviewed
Aug 24, 2023
bukepo
reviewed
Aug 28, 2023
| NODE_TYPE_END = 2; | ||
| NODE_TYPE_SLEEPY_END = 3; | ||
| NODE_TYPE_MINIMAL_END = 4; | ||
| message Duration { |
There was a problem hiding this comment.
This is borrowed from google.
I wonder whether we need it to be so precise. It probably acceptable to use uint32_t representing the duration in seconds.
There was a problem hiding this comment.
How about to keep this Duration format currently: 1. for age / timeout use case, only the seconds field is populated, so the wired payload size is optimized without the nano field. 2. compatible with the parsing proto logic in upper layer, and extensible if we need to have finer nano granularity in future.
abtink
reviewed
Aug 28, 2023
bukepo
approved these changes
Aug 31, 2023
jwhui
changed the title
jwhui
reviewed
Sep 7, 2023
jwhui
reviewed
Sep 8, 2023
jwhui
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.