Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mbedtls] move mbedtls to 2.28.0 LTS version #7539

Merged
merged 5 commits into from
Apr 7, 2022
Merged

[mbedtls] move mbedtls to 2.28.0 LTS version #7539

merged 5 commits into from
Apr 7, 2022

Conversation

jwhui
Copy link
Member

@jwhui jwhui commented Mar 29, 2022

As discussed in #7527 .

@jwhui jwhui added the security label Mar 29, 2022
@size-report
Copy link

size-report bot commented Mar 29, 2022 •
edited
Loading

Size Report of OpenThread

Merging #7539 into main(fdf3c30).

name branch text data bss total
ot-cli-ftd_1.1 main 459392 780 60480 520652
#7539 459392 780 60480 520652
+/- 0 0 0 0
ot-cli-mtd_1.1 main 378472 780 50360 429612
#7539 378472 780 50360 429612
+/- 0 0 0 0
ot-ncp-ftd_1.1 main 441908 780 59536 502224
#7539 441908 780 59536 502224
+/- 0 0 0 0
ot-ncp-mtd_1.1 main 363572 780 49416 413768
#7539 363572 780 49416 413768
+/- 0 0 0 0
ot-rcp_1.1 main 57876 564 19964 78404
#7539 57876 564 19964 78404
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.1 main 45470 0 4228 49698
#7539 45470 0 4228 49698
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.1 main 38152 0 4228 42380
#7539 38152 0 4228 42380
+/- 0 0 0 0
libopenthread-ftd.a_1.1 main 239098 20 38874 277992
#7539 239098 20 38874 277992
+/- 0 0 0 0
libopenthread-mtd.a_1.1 main 170979 20 28754 199753
#7539 170979 20 28754 199753
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.1 main 31519 0 5852 37371
#7539 31519 0 5852 37371
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.1 main 26363 0 5852 32215
#7539 26363 0 5852 32215
+/- 0 0 0 0
libopenthread-rcp.a_1.1 main 8826 0 4988 13814
#7539 8826 0 4988 13814
+/- 0 0 0 0
libopenthread-radio.a_1.1 main 16019 0 174 16193
#7539 16019 0 174 16193
+/- 0 0 0 0
ot-cli-ftd_1.2 main 482544 780 70160 553484
#7539 482544 780 70160 553484
+/- 0 0 0 0
ot-cli-mtd_1.2 main 393976 780 51608 446364
#7539 393976 780 51608 446364
+/- 0 0 0 0
ot-ncp-ftd_1.2 main 464028 780 69208 534016
#7539 464028 780 69208 534016
+/- 0 0 0 0
ot-ncp-mtd_1.2 main 377692 780 50656 429128
#7539 377692 780 50656 429128
+/- 0 0 0 0
ot-rcp_1.2 main 60212 564 20524 81300
#7539 60212 564 20524 81300
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.2 main 48241 0 4228 52469
#7539 48241 0 4228 52469
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.2 main 40341 0 4228 44569
#7539 40341 0 4228 44569
+/- 0 0 0 0
libopenthread-ftd.a_1.2 main 258560 20 48010 306590
#7539 258560 20 48010 306590
+/- 0 0 0 0
libopenthread-mtd.a_1.2 main 183300 20 29458 212778
#7539 183300 20 29458 212778
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.2 main 33325 0 5852 39177
#7539 33325 0 5852 39177
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.2 main 27705 0 5852 33557
#7539 27705 0 5852 33557
+/- 0 0 0 0
libopenthread-rcp.a_1.2 main 8992 0 4988 13980
#7539 8992 0 4988 13980
+/- 0 0 0 0
libopenthread-radio.a_1.2 main 17015 0 198 17213
#7539 17015 0 198 17213
+/- 0 0 0 0

@jwhui jwhui force-pushed the mbedtls branch 8 times, most recently from 3acc8f3 to 2b5a8f4 Compare March 29, 2022 06:38
@jwhui jwhui requested a review from bukepo March 29, 2022 06:40
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #7539 (0fce0ef) into main (fdf3c30) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7539      +/-   ##
==========================================
- Coverage   87.16%   86.99%   -0.18%     
==========================================
  Files         494      487       -7     
  Lines       61921    59949    -1972     
==========================================
- Hits        53976    52152    -1824     
+ Misses       7945     7797     -148
Impacted Files Coverage Δ
src/core/net/ip6.hpp 75.00% <0.00%> (-25.00%) ⬇️
src/core/api/icmp6_api.cpp 22.22% <0.00%> (-22.23%) ⬇️
src/lib/spinel/spinel_buffer.cpp 82.33% <0.00%> (-16.32%) ⬇️
src/core/thread/mle_router.hpp 79.31% <0.00%> (-6.90%) ⬇️
src/core/coap/coap.hpp 83.87% <0.00%> (-6.46%) ⬇️
examples/apps/ncp/main.c 65.00% <0.00%> (-6.43%) ⬇️
src/ncp/ncp_base_ftd.cpp 55.35% <0.00%> (-5.86%) ⬇️
src/lib/spinel/spinel_encoder.cpp 75.39% <0.00%> (-5.56%) ⬇️
src/core/thread/mesh_forwarder_ftd.cpp 86.24% <0.00%> (-5.41%) ⬇️
src/core/net/icmp6.hpp 95.00% <0.00%> (-5.00%) ⬇️
... and 67 more

@gabekassel
Copy link
Contributor

I've tested this in two OTBR implementations on host side with EFR32 and Qorvo radios. Devices can attach, pass traffic, converge over TREL, etc. I've not tested an end device or joiner functionality yet.

gabekassel
gabekassel approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@gabekassel gabekassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels shippable based on my testing so far, but would love others to do more bench testing.

LuDuda
LuDuda approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested that commissioner & joiner works on nRF52840, also cross-checked with 2.25.

@hemanth-silabs
Copy link
Contributor

Tested basic commissioning ping and UDP tests on EFR32MG12. LGTM 👍

@jwhui jwhui removed the request for review from bukepo April 6, 2022 22:59
@jwhui jwhui changed the title [mbedtls] move mbedtls to 2.28 LTS version [mbedtls] move mbedtls to 2.28.0 LTS version Apr 7, 2022
@jwhui jwhui merged commit 9be687a into openthread:main Apr 7, 2022
@jwhui jwhui deleted the mbedtls branch April 7, 2022 17:35
lmnotran pushed a commit to SiliconLabs/openthread that referenced this pull request Nov 11, 2022
@suveshpratapa
Pull request #146: Update openthread stack 687e04f->f538240cd
9afc5e6 
Merge in WMN_STACKS/openthread from task/update-openthread-commit to develop/21q4

* commit 'b5f6200f6368c566a50afeec0b96c734fa341890': (48 commits)
  [instance] move `otMessageGetBufferInfo()` impl to `Instance` (openthread#7573)
  [cli] allow to run `factoryreset` under the diag mode (openthread#7566)
  [docs] community discussion change (openthread#7507)
  [mesh-forwarder] update `LogMessage()` to include ECN from IPv6 header (openthread#7562)
  [thci] increase BBR Sequence Number when dataset changes (openthread#7558)
  [tcp] remove extraneous #define and restrict inclusion of TCPlp headers (openthread#7570)
  [posix] stop setting up and de-initializing uninitialized modules when dry run (openthread#7550)
  [mbedtls] move mbedtls to 2.28.0 LTS version (openthread#7539)
  [ip6] new methods in `Header` and add unit test (openthread#7561)
  [mac] remove beacons payload (openthread#7472)
  [tests] disable check in test_firewall.py (openthread#7569)
  [message] static assert `Meatdata::mPriority` is of proper bit size (openthread#7563)
  [message] add timestamp field in `Message` metadata (openthread#7554)
  [thci] do not set `P_slaac` flag for Domain prefix (openthread#7557)
  [mesh-forwarder] fix and enhance `LogMessage()` (openthread#7556)
  [sub-mac] fix `semiWindow` overflow in `GetCslWindowEdges()` (openthread#7549)
  [ip6] set priority on fragments when fragmenting an IPv6 datagram (openthread#7555)
  [ip6] copy the parsed ECN value from IPv6 msg in `MessageInfo` (openthread#7548)
  [ip6] add header `ip6_types.hpp` for common types and constants (openthread#7547)
  [mle] simplify sending/processing of address solicit/response (openthread#7544)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabekassel gabekassel gabekassel approved these changes

@LuDuda LuDuda LuDuda approved these changes

@hemanth-silabs hemanth-silabs hemanth-silabs approved these changes

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwhui @gabekassel @hemanth-silabs @LuDuda