POW Registration allowance/disallowance #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardogr
reviewed
Oct 13, 2023
| Self::if_subnet_allows_registration(netuid), | ||
| Self::get_network_pow_registration_allowed(netuid), |
There was a problem hiding this comment.
is there some idiomatic reason for this name change?
I thjink the previous one has a good naming, maybe something like.... Self::subnet_allows_registrations(netuid) which could fit with the context and its semantics. What do you think?
There was a problem hiding this comment.
if_subnet_allows_registration was a duplicate of another function which was already implemented.
ifrit98
approved these changes
Oct 20, 2023
Yep, i do need to update these! Good catch |
|
Burn adjustment tests fixed |
ifrit98
approved these changes
Oct 26, 2023
Fixed! Thank you for catching this. |
shibshib
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sudo call which separately manages whether or not POW registration is enabled for a subnet.