Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/batch set commit weights #2485

Open
wants to merge 19 commits into
base: staging
Choose a base branch
from
Open

Feat/batch set commit weights #2485

wants to merge 19 commits into from
+1,466 −23

Conversation

camfairchild
Copy link
Collaborator

@camfairchild camfairchild commented Nov 27, 2024 •
edited
Loading

Adds methods for new extrinsics of batch_set_weights and batch_commit_weights from: opentensor/subtensor#1022

Includes new e2e tests passing locally on relevant subtensor feature branch.

@camfairchild camfairchild mentioned this pull request Nov 27, 2024
Open
13 tasks
@camfairchild camfairchild linked an issue Nov 27, 2024 that may be closed by this pull request
Add batched extrinsics for setting weights opentensor/subtensor#1018
Open
5 tasks
thewhaleking
thewhaleking requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few issues that need to be resolved. If the weightss and uidss is because they're lists of lists of weights, maybe name it weights_matrix or nested_weights or something.

bittensor/core/subtensor.py Outdated Show resolved Hide resolved
bittensor/core/subtensor.py Outdated Show resolved Hide resolved
bittensor/core/subtensor.py Outdated Show resolved Hide resolved
bittensor/core/subtensor.py Outdated Show resolved Hide resolved
bittensor/core/subtensor.py Outdated Show resolved Hide resolved
bittensor/core/async_subtensor.py Outdated Show resolved Hide resolved
bittensor/core/extrinsics/async_weights.py Outdated Show resolved Hide resolved
bittensor/core/extrinsics/async_weights.py Outdated Show resolved Hide resolved
bittensor/core/extrinsics/async_weights.py Outdated Show resolved Hide resolved
bittensor/core/extrinsics/set_weights.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewhaleking thewhaleking thewhaleking requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add batched extrinsics for setting weights
2 participants
@camfairchild @thewhaleking