Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds E2E Tests for wallet creation commands #2145

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

  • We are testing these commands
  1. btcli wallet create
  2. btcli wallet new_coldkey
  3. btcli wallet new_hotkey
  4. btcli wallet list
  • In each test, we verify the wallet is displayed along with the key in correct format through the cli
  • We also test the physical existence of wallets in the system (including coldkeys and hotkeys)

@ibraheem-opentensor ibraheem-opentensor requested a review from a team July 18, 2024 00:34
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty well
Just left couple of comments

@ibraheem-opentensor ibraheem-opentensor merged commit ccbd86b into staging Jul 18, 2024
32 checks passed
@thewhaleking thewhaleking deleted the tests/abe/e2e-wallet-creation branch October 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants