Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds timeout for e2e tests #2141

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

ibraheem-opentensor
Copy link
Contributor

In some cases where the e2e tests keep running indefinitely, we need a timeout to halt the tests to preserve credits.
Currently, we've set 45 minutes - we will be observing if this is good enough with PRs in staging before rolling it out.

@ibraheem-opentensor ibraheem-opentensor requested a review from a team July 16, 2024 18:14
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 45 mins is enough for now.
LGTM

@ibraheem-opentensor ibraheem-opentensor merged commit 26f2bf7 into staging Jul 16, 2024
30 of 31 checks passed
@thewhaleking thewhaleking deleted the ench/add-e2e-timeout branch October 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants