fix: coldkeypub usage instead of coldkey for arbitration_stats #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rapiiidooo
force-pushed
the
check_coldkey_swap_from_pub
branch
from
5bb4f26 to
4ad27ad
Compare
alex-drocks
approved these changes
Jul 13, 2024
Rapiiidooo
force-pushed
the
check_coldkey_swap_from_pub
branch
5 times, most recently
from
ae9326f to
213a7e0
Compare
|
Hey @Rapiiidooo |
Rapiiidooo
force-pushed
the
check_coldkey_swap_from_pub
branch
from
e8d9a02 to
b880dc2
Compare
|
Thank you 😄 ! It is all good now @ibraheem-opentensor |
camfairchild
approved these changes
Jul 16, 2024
gus-opentensor
approved these changes
Jul 16, 2024
ibraheem-opentensor
merged commit 9f99bd4
into
opentensor:staging
30 of 31 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the coldkeypub instead of coldkey
Change the method that performs a check of the current arbitration data (if any), use the coldkeypub instead of the coldkey.
It increases the performance as the file decryption doesn't need to occur.
It's also more secure as the password should not be required for that stat.
Quantitative Performance Benefits
Few seconds.
Verification Process
Re-ran the method and it works correctly.
Release Notes