Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child Hotkeys #2071

Merged
merged 39 commits into from
Aug 9, 2024
Merged

Child Hotkeys #2071

merged 39 commits into from
Aug 9, 2024

Conversation

opendansor
Copy link

We need to integrate new extrinsics related to child key management into our Python codebase and add corresponding CLI commands. These extrinsics allow users to set and revoke child keys for hotkeys on specific subnets. This feature enhances the flexibility of our stake delegation system.

@opendansor opendansor force-pushed the feature/opendansor/child_hotkeys branch from 35a205b to d2bc588 Compare June 26, 2024 23:10
@opendansor opendansor self-assigned this Jun 27, 2024
@opendansor opendansor added the feature new feature added label Jul 2, 2024
gus-opentensor
gus-opentensor previously approved these changes Jul 9, 2024
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no questions about implementation. I left a few comments regarding the style and tests.

Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thewhaleking
thewhaleking previously approved these changes Aug 9, 2024
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. There's some nitpicks here and there, but I have to redo this in btcli anyway, so I'll just fix it all there.

gus-opentensor
gus-opentensor previously approved these changes Aug 9, 2024
opendansor added 2 commits August 9, 2024 10:34
@opendansor opendansor merged commit 98d0af6 into staging Aug 9, 2024
35 of 36 checks passed
@roman-opentensor roman-opentensor deleted the feature/opendansor/child_hotkeys branch August 9, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bittensor feature new feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants