-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child Hotkeys #2071
Child Hotkeys #2071
Conversation
35a205b
to
d2bc588
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no questions about implementation. I left a few comments regarding the style and tests.
tests/e2e_tests/subcommands/stake/test_set_revoke_child_hotkeys.py
Outdated
Show resolved
Hide resolved
tests/e2e_tests/subcommands/stake/test_set_revoke_child_hotkeys.py
Outdated
Show resolved
Hide resolved
tests/e2e_tests/subcommands/stake/test_set_revoke_child_hotkeys.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. There's some nitpicks here and there, but I have to redo this in btcli anyway, so I'll just fix it all there.
a18fcd5
We need to integrate new extrinsics related to child key management into our Python codebase and add corresponding CLI commands. These extrinsics allow users to set and revoke child keys for hotkeys on specific subnets. This feature enhances the flexibility of our stake delegation system.