Tdf3 + Nano = ❤️ #47
Tdf3 + Nano = ❤️ #47
Conversation
# Conflicts: # cli/package-lock.json # sample-web-app/package-lock.json
|
Is this ready to review? It doesn't look like it builds yet, and it isn't clear how to initialize/use/test it. Maybe add a test scenario to the CLI tool? |
There was a problem hiding this comment.
It looks good, but you'll probably want a clean run of cd lib && npm test in the GitHub actions. I'm guessing there is still some cleanup there.
I'm guessing we'll need some more extreme refactoring to get the AuthProvider class working with the old code, so I'm fine with committing it without that now.
Probably we should commit this as soon as we can get it building and unit tests passing, then we can shard out the various refactoring tasks easier, such as any node->web conversions, addition of types, or changes to auth.
| @@ -0,0 +1,133 @@ | |||
| // Karma configuration | |||
There was a problem hiding this comment.
Is this file still used?
| @@ -0,0 +1,344 @@ | |||
| [](https://github.com/opentdf/tdf3-js/actions/workflows/build.yaml) | |||
There was a problem hiding this comment.
Is this file used by typedoc or something? You can probably just delete it otherwise
| @@ -0,0 +1,67 @@ | |||
| import { Client as ClientTdf3 } from '../tdf3/src/client'; | |||
There was a problem hiding this comment.
It is spelled facade. But this is great! 👍
# Conflicts: # cli/package-lock.json # lib/package-lock.json # lib/package.json # sample-web-app/package-lock.json
|
SonarCloud Quality Gate failed.
|
No description provided.