Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix incorrect dataset i.v. guard #41

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

dmihalcik-virtru
Copy link
Member

  • We are looking for 3 bytes, not 3 nibbles

- We are looking for 3 bytes, not 3 nibbles
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner April 25, 2022 13:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@patmantru patmantru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have an automated test...

@dmihalcik-virtru
Copy link
Member Author

This is blocked by #37, if anyone wants to review that first 🙏

@dmihalcik-virtru dmihalcik-virtru merged commit c8f0836 into main Apr 27, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/i-kn0-my-lgscale branch April 27, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants