🔥 Refactor to remove TDF helper class #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
Oct 24, 2023
•
dmihalcik-virtru
commented
- Functional refactor of tdf.ts
- This is a step toward a more functional set of internals that will be simpler to refactor
- notably this is a step toward refactoring KAS, policy, metadata, and attribute related functionality to be shared between nanotdf and json container formats
dmihalcik-virtru
force-pushed
the
feature/simplify
branch
from
2c33a39 to
61f0cff
Compare
A functional refactor of tdf.ts - Remove TDF helper class - Since that eliminates the ability to mock out helper methods, disable where needed, and add additional functionality to test server where possible/doable.
dmihalcik-virtru
force-pushed
the
feature/simplify
branch
from
46206be to
2f37093
Compare
dmihalcik-virtru
changed the title
ivanovSPvirtru
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.