Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will it do it? #237

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions lib/tdf3/src/binary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,7 @@ class ArrayBufferBinary extends Binary {

override asString(): string {
const uint8Array = new Uint8Array(this.value);
let str = '';
for (let i = 0; i < uint8Array.length; i++) {
str = str + String.fromCharCode(uint8Array[i]);
}
return str;
return unescape(encodeURIComponent(new TextDecoder().decode(uint8Array)));
}

override isArrayBuffer(): boolean {
Expand Down Expand Up @@ -127,11 +123,7 @@ class ByteArrayBinary extends Binary {

override asString(): string {
const uint8Array = new Uint8Array(this.value);
let str = '';
for (let i = 0; i < uint8Array.length; i++) {
str = str + String.fromCharCode(uint8Array[i]);
}
return str;
return unescape(encodeURIComponent(new TextDecoder().decode(uint8Array)));
}

override isByteArray(): boolean {
Expand Down