Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix sed and grep errors and x-plat problems #133

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

dmihalcik-virtru
Copy link
Member

  • sed -I is not in the posix standard, and has different properties, so either don't use it or work around it
  • there was an error in the grep logic so I made it more straightforward and used the long versions of the arguments for clarity. IDK if they are all standard but the arguments were in the man pages on both macOS and ubuntu (latest)

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner January 18, 2023 15:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit 69dde3a into opentdf:main Jan 18, 2023
@dmihalcik-virtru dmihalcik-virtru deleted the feature/sed-better branch January 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants