🐛 Typescript fixes #113
Merged
🐛 Typescript fixes #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
Nov 28, 2022
•
dmihalcik-virtru
commented
- Disables @ts-ignore on tdf.js
- Enable strict mode in lint again
- Fixes a bunch of errors that fall out of that:
- jose import of x509 had incorrect call
- upsert response not being set
danielRicaud
previously approved these changes
Nov 28, 2022
- Disables @ts-ignore on tdf.js - Fixes a bunch of errors that fall out of that: - jose import of x509 had incorrect call - upsert response not being set
dmihalcik-virtru
force-pushed
the
feature/tdf3-typscript-fixes
branch
from
566f2f6 to
5e75935
Compare
sujankota
approved these changes
Nov 29, 2022
| parseInt( | ||
| this.manifest.encryptionInformation.integrityInformation.encryptedSegmentSizeDefault | ||
| ) || DEFAULT_SEGMENT_SIZE; | ||
| const defaultSegmentSize = |
There was a problem hiding this comment.
I think we want DEFAULT_SEGMENT_SIZE not 0
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.