Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move tests around a bit #110

Merged

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Nov 22, 2022

  • Move mocha tests from tdf3/tests to tests/mocha
  • Move web-test-runner tests from test into tests/web
  • Deletes a bunch of defunct and unused tests
  • Updates a few tests to be written in typescript. a few JS ones remain, though
  • Somehow there are some lint errors now? I fixed them
  • Why? This prevents accidentally including test, fixture, or mock code in the built artifacts, simplifies coverage and test configurations by reducing the number of 'excludes' we have to add, and otherwise gets us closer to a simpler layout

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner November 22, 2022 21:28
pflynn-virtru
pflynn-virtru previously approved these changes Nov 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit fedb94b into opentdf:main Nov 28, 2022
@dmihalcik-virtru dmihalcik-virtru deleted the feature/another-cleanups branch November 28, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants