feat(core): adds bulk rewrap to sdk and service #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdominicreed
force-pushed
the
feat/bulk-rewrap
branch
2 times, most recently
from
3cbcaa1 to
d20add1
Compare
go structs of new rewrap API Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
imdominicreed
force-pushed
the
feat/bulk-rewrap
branch
from
d47accc to
767e621
Compare
Summary: Test Plan:
Summary: Test Plan:
imdominicreed
changed the title
strantalis
reviewed
Jan 16, 2025
There was a problem hiding this comment.
@imdominicreed Can we make sure to add comments to the code. For example adding comments to the WithX options and anything that exposed from the sdk.
Summary: Test Plan:
patmantru
previously approved these changes
Jan 17, 2025
dmihalcik-virtru
previously approved these changes
Jan 17, 2025
Co-authored-by: Dave Mihalcik <[email protected]>
imdominicreed
dismissed stale reviews from dmihalcik-virtru and patmantru
via
9a0c5a1
imdominicreed
requested review from
patmantru,
dmihalcik-virtru and
biscoe916
biscoe916
approved these changes
Jan 17, 2025
This was referenced Jan 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.23](protocol/go/v0.2.22...protocol/go/v0.2.23) (2025-01-17) ### Features * **core:** adds bulk rewrap to sdk and service ([#1835](#1835)) ([11698ae](11698ae)) ### Bug Fixes * **core:** Update fixtures and flattening in sdk and service ([#1827](#1827)) ([d6d6a7a](d6d6a7a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.26](sdk/v0.3.25...sdk/v0.3.26) (2025-01-21) ### Features * **core:** adds bulk rewrap to sdk and service ([#1835](#1835)) ([11698ae](11698ae)) * **core:** Adds ErrInvalidPerSchema ([#1860](#1860)) ([456639e](456639e)) ### Bug Fixes * **core:** Autobump sdk ([#1863](#1863)) ([855cb2b](855cb2b)) * **sdk:** everything is `mixedSplits` now ([#1861](#1861)) ([ba78f14](ba78f14)) * **sdk:** Fixed token expiration time ([#1854](#1854)) ([c3cda1b](c3cda1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.38](service/v0.4.37...service/v0.4.38) (2025-01-21) ### Features * **core:** adds bulk rewrap to sdk and service ([#1835](#1835)) ([11698ae](11698ae)) ### Bug Fixes * **core:** Autobump service ([#1864](#1864)) ([f9d149b](f9d149b)) * **core:** Autobump service ([#1867](#1867)) ([b8f5101](b8f5101)) * **core:** reduces GetAttributeValuesByFqns calls in getDecisions ([#1857](#1857)) ([5379baf](5379baf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Testing Instructions