Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: table loading state #627

Merged
merged 8 commits into from
Jan 15, 2025
Merged

[Platform]: table loading state #627

merged 8 commits into from
Jan 15, 2025

Conversation

chinmehta
Copy link
Contributor

@chinmehta chinmehta commented Jan 7, 2025

[Platform]: table loading state

Description

  • Adding cell level loading to client side table and generic skeleton for server side table to minimise layout shift and improve UX.
  • Modified loading message to show some API calls can take more time, it will be loaded after 5secs(can be changed).
  • Added Skeleton for Insilico Chart component.
  • Loading state for downloads page

Issue: (link)
Deploy preview: https://deploy-preview-627--ot-platform.netlify.app/

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

@chinmehta chinmehta requested review from carcruz and gjmcn January 7, 2025 15:24
@carcruz carcruz merged commit 622d918 into main Jan 15, 2025
11 checks passed
@carcruz carcruz deleted the cm-table-loading branch January 15, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants