Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable editor accessibilitySupport by default #1798

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Oct 18, 2022

Types

Background or solution

Changelog

  • 默认关闭 editor.accessibilitySupport

@Aaaaash Aaaaash force-pushed the chore/disbale-accessibility-support-by-default branch from 45e1db4 to 07f14d9 Compare October 18, 2022 05:36
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 57.59% // Head: 57.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (07f14d9) compared to base (fd9f031).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.20    #1798   +/-   ##
=======================================
  Coverage   57.59%   57.59%           
=======================================
  Files        1257     1257           
  Lines       78470    78469    -1     
  Branches    16439    16438    -1     
=======================================
+ Hits        45191    45194    +3     
+ Misses      30277    30274    -3     
+ Partials     3002     3001    -1     
Flag Coverage Δ
jsdom 52.39% <ø> (+<0.01%) ⬆️
node 15.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/editor/src/browser/preference/schema.ts 100.00% <ø> (ø)
...xt/src/browser/services/file-tree-model.service.ts 51.85% <0.00%> (-0.06%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.59% <0.00%> (+0.57%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.62% <0.00%> (+0.62%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit d5d771b into v2.20 Oct 18, 2022
@erha19 erha19 deleted the chore/disbale-accessibility-support-by-default branch October 18, 2022 07:38
erha19 added a commit that referenced this pull request Oct 24, 2022
…1340)

* chore: disable editor accessibilitySupport by default (#1798)

* style: fix --kt-sekectDropdown-teamForeground style (#1797)

* feat: migrate walk through snippets provider to file-scheme module

Co-authored-by: Dan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants