Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve file dialog tree style #1770

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 11, 2022

Types

  • 💄 Style Changes

Background or solution

before:
image
after:
image

Changelog

improve file dialog tree style

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 57.59% // Head: 57.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ac096ed) compared to base (fd9f031).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.20    #1770   +/-   ##
=======================================
  Coverage   57.59%   57.59%           
=======================================
  Files        1257     1257           
  Lines       78470    78470           
  Branches    16439    16439           
=======================================
+ Hits        45191    45195    +4     
+ Misses      30277    30274    -3     
+ Partials     3002     3001    -1     
Flag Coverage Δ
jsdom 52.39% <ø> (+<0.01%) ⬆️
node 15.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/theme/src/browser/workbench.theme.service.ts 71.59% <0.00%> (+0.57%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.62% <0.00%> (+0.62%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 force-pushed the style/improve-file-dialog-style branch from f796eb0 to ac096ed Compare October 12, 2022 01:52
@erha19 erha19 changed the base branch from main to v2.20 October 12, 2022 01:53
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
@erha19 erha19 merged commit 8ca0b27 into v2.20 Oct 12, 2022
@erha19 erha19 deleted the style/improve-file-dialog-style branch October 12, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants