Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editor copy path command #1745

Merged
merged 2 commits into from
Oct 9, 2022
Merged

fix: editor copy path command #1745

merged 2 commits into from
Oct 9, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Sep 30, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

fix editor copy path command

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 57.59% // Head: 57.59% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1dd07df) compared to base (147cd7a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.20    #1745      +/-   ##
==========================================
- Coverage   57.59%   57.59%   -0.01%     
==========================================
  Files        1257     1257              
  Lines       78455    78455              
  Branches    16433    16433              
==========================================
- Hits        45188    45186       -2     
- Misses      30268    30270       +2     
  Partials     2999     2999              
Flag Coverage Δ
jsdom 52.39% <ø> (-0.01%) ⬇️
node 15.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain
Copy link
Member

bytemain commented Oct 8, 2022

这个有可能补个单测吗?这种小问题让单测覆盖一下吧

@erha19
Copy link
Member Author

erha19 commented Oct 8, 2022

这个有可能补个单测吗?这种小问题让单测覆盖一下吧

这个感觉没啥好补的,就是编辑器右键菜单参数错了

@erha19
Copy link
Member Author

erha19 commented Oct 8, 2022

@bytemain 追加了简单的单侧固定参数格式

@erha19 erha19 merged commit 09df89e into v2.20 Oct 9, 2022
@erha19 erha19 deleted the fix/editor-copy-path-menu branch October 9, 2022 03:56
yantze pushed a commit that referenced this pull request Oct 10, 2022
* fix: editor copy path command

* test: add editor command args unit test
# Conflicts:
#	packages/editor/src/browser/editor.contribution.ts
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants