Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: box panel generate child with className #1706

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Background or solution

原来我们将 Top Slot 的 zIndex 设置的比较高以便于我们顶部的 popOver 可以展示出来。

所以 #1676 这个修复在支付宝小程序 IDE 上还是没生效,我们现在可以动态调整 zIndex,但是 BoxPanel 并没有生成这些 SlotRenderer 的 className,导致我们取不到这个 DOM

CleanShot 2022-09-22 at 15 14 07@2x

Changelog

BoxPanel generate child with className

@bytemain
Copy link
Member Author

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.20.3-next-1663831226.0 publish successful! You can install prerelease version via npm install [email protected] @bytemain

2.20.3-next-1663831226.0

@bytemain
Copy link
Member Author

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.20.3-next-1663831756.0 publish successful! You can install prerelease version via npm install [email protected] @bytemain

2.20.3-next-1663831756.0

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 57.58% // Head: 57.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9cf362f) compared to base (4284ede).
Patch coverage: 46.16% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.20    #1706   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files        1255     1255           
  Lines       78349    78375   +26     
  Branches    16406    16416   +10     
=======================================
+ Hits        45115    45131   +16     
- Misses      30237    30245    +8     
- Partials     2997     2999    +2     
Flag Coverage Δ
jsdom 52.39% <43.70%> (+<0.01%) ⬆️
node 15.82% <24.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/comments/src/common/index.ts 100.00% <ø> (ø)
packages/connection/src/node/connect.ts 100.00% <ø> (ø)
packages/core-browser/src/context-key.ts 100.00% <ø> (ø)
...browser/src/extensions/extensions-point.service.ts 29.54% <0.00%> (ø)
...core-browser/src/extensions/schema/browserViews.ts 100.00% <ø> (ø)
...ages/core-browser/src/extensions/schema/toolbar.ts 100.00% <ø> (ø)
packages/core-browser/src/monaco/index.ts 100.00% <ø> (ø)
packages/core-browser/src/opener/command-opener.ts 21.05% <ø> (ø)
packages/core-browser/src/quick-open/index.ts 77.63% <ø> (ø)
...es/core-browser/src/services/status-bar-service.ts 100.00% <ø> (ø)
... and 205 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain changed the title WIP: feat: box panel generate child with className feat: box panel generate child with className Sep 22, 2022
@erha19 erha19 merged commit 713e186 into v2.20 Sep 27, 2022
@erha19 erha19 deleted the feat/update-layout branch September 27, 2022 02:34
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants