Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve terminal and editor tabs style #1665

Merged
merged 5 commits into from
Sep 19, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Sep 16, 2022

Types

  • 🐛 Bug Fixes
  • 💄 Style Changes

Background or solution

修复 Terminal Tab 选中态样式以及编辑器 Tab 无法滚动到底部的问题

Changelog

improve terminal and editor tabs style

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 57.56% // Head: 57.59% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4d1f857) compared to base (04b2bbf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.20    #1665      +/-   ##
==========================================
+ Coverage   57.56%   57.59%   +0.02%     
==========================================
  Files        1256     1255       -1     
  Lines       78355    78346       -9     
  Branches    16408    16404       -4     
==========================================
+ Hits        45102    45120      +18     
+ Misses      30255    30230      -25     
+ Partials     2998     2996       -2     
Flag Coverage Δ
jsdom 52.40% <ø> (+0.02%) ⬆️
node 15.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/file-service/src/node/file-service.ts 76.70% <0.00%> (-0.07%) ⬇️
packages/comments/src/common/index.ts 100.00% <0.00%> (ø)
packages/file-service/src/common/index.ts 100.00% <0.00%> (ø)
...ion/src/browser/vscode/api/main.thread.comments.ts 66.90% <0.00%> (ø)
packages/file-service/src/common/file-ext.ts
...file-service/src/node/disk-file-system.provider.ts 78.52% <0.00%> (+0.06%) ⬆️
...tension/src/hosted/api/vscode/ext.host.comments.ts 63.90% <0.00%> (+0.18%) ⬆️
...kages/theme/src/browser/workbench.theme.service.ts 71.34% <0.00%> (+0.58%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.62% <0.00%> (+0.62%) ⬆️
packages/extension/src/common/vscode/converter.ts 41.08% <0.00%> (+2.16%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19
Copy link
Member Author

erha19 commented Sep 19, 2022

vscode-uri 3.0.2 ... 3.0.5

Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@erha19 erha19 merged commit 4e95233 into v2.20 Sep 19, 2022
@erha19 erha19 deleted the style/improve-editor-and-terminal-tabs-style branch September 19, 2022 08:17
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants