Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-close debug terminal after finished or closed #1652

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Sep 13, 2022

Types

  • 🐛 Bug Fixes
  • 💄 Style Changes

Background or solution

兼容 JavaScript Debugger 插件至最新 1.71.0 版本,解决调试终端不退出问题

close #1637.
close #1423.

Changelog

auto-close debug terminal after finished or closed

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 57.69% // Head: 57.62% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (f20d4db) compared to base (0a64da0).
Patch coverage: 7.89% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   57.69%   57.62%   -0.07%     
==========================================
  Files        1254     1255       +1     
  Lines       78152    78262     +110     
  Branches    16333    16376      +43     
==========================================
+ Hits        45088    45101      +13     
- Misses      30093    30178      +85     
- Partials     2971     2983      +12     
Flag Coverage Δ
jsdom 52.43% <7.89%> (-0.06%) ⬇️
node 15.82% <0.87%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/debug/src/browser/debug-session.ts 10.91% <0.00%> (-0.04%) ⬇️
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
packages/terminal-next/src/browser/terminal.api.ts 0.00% <0.00%> (ø)
packages/terminal-next/src/common/api.ts 100.00% <ø> (ø)
packages/terminal-next/src/common/pty.ts 87.50% <ø> (ø)
packages/debug/src/common/terminal.ts 5.20% <5.20%> (ø)
...scode/api/debug/extension-debug-session-factory.ts 42.22% <25.00%> (-1.37%) ⬇️
packages/debug/src/common/index.ts 100.00% <100.00%> (ø)
...ages/theme/src/common/color-tokens/custom/badge.ts 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 093215e into main Sep 13, 2022
@erha19 erha19 deleted the fix/js-debug-1.68.x branch September 13, 2022 09:13
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 进程退出后终端类型调试不会自动终止 [BUG] 不兼容 JavaScript Debugger 1.68.0
2 participants