Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add missing type for file-service #1611

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

situ2001
Copy link
Member

@situ2001 situ2001 commented Aug 31, 2022

Types

  • 🪚 Refactors

Changelog

  • refactor: add missing type for method of DiskFsProviderClient
  • refactor: add missing type for method of DiskFileSystemProvider

hacke2
hacke2 previously approved these changes Aug 31, 2022
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 57.66% // Head: 57.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2166c38) compared to base (e7d36bd).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   57.66%   57.66%   -0.01%     
==========================================
  Files        1253     1254       +1     
  Lines       78168    78174       +6     
  Branches    16331    16332       +1     
==========================================
+ Hits        45076    45078       +2     
- Misses      30123    30125       +2     
- Partials     2969     2971       +2     
Flag Coverage Δ
jsdom 52.46% <40.00%> (-0.01%) ⬇️
node 15.84% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervice/src/browser/file-service-provider-client.ts 24.07% <0.00%> (ø)
...file-service/src/node/disk-file-system.provider.ts 78.46% <0.00%> (-0.07%) ⬇️
packages/file-service/src/common/file-ext.ts 100.00% <100.00%> (ø)
packages/file-service/src/common/index.ts 100.00% <100.00%> (ø)
packages/file-service/src/node/file-service.ts 76.77% <100.00%> (+0.06%) ⬆️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 70.76% <0.00%> (-0.59%) ⬇️
...tension/src/hosted/api/vscode/ext.host.treeview.ts 53.56% <0.00%> (-0.34%) ⬇️
...xt/src/browser/services/file-tree-model.service.ts 51.91% <0.00%> (-0.06%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 60.44% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@situ2001 situ2001 changed the title refactor: add missing type for method of DiskFsProviderClient refactor: add missing type for file-service Aug 31, 2022
@erha19 erha19 added this to the 2.21 milestone Aug 31, 2022
@erha19 erha19 merged commit eae560e into opensumi:main Sep 13, 2022
yantze pushed a commit that referenced this pull request Sep 19, 2022
* refactor: add missing type for method of `DiskFsProviderClient`

* refactor: add missing type for method of `DiskFileSystemProvider`

* refactor: move definition of file ext to separated file

* refactor: add missing type for method of `FileService`

* feat: add more file type
bytemain pushed a commit that referenced this pull request Sep 27, 2022
* refactor: add missing type for method of `DiskFsProviderClient`

* refactor: add missing type for method of `DiskFileSystemProvider`

* refactor: move definition of file ext to separated file

* refactor: add missing type for method of `FileService`

* feat: add more file type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants