Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SCM 模块【更多】按钮文本缺失 #2903

Closed
zhuzeyu22 opened this issue Jul 18, 2023 · 1 comment
Closed

[BUG] SCM 模块【更多】按钮文本缺失 #2903

zhuzeyu22 opened this issue Jul 18, 2023 · 1 comment
Labels
🐞 bug Something isn't working

Comments

@zhuzeyu22
Copy link
Contributor

TitleActionList 里面没有提供 more title 的 tips 的文本编辑的地方

image

希望可以增加文本提示,并且支持多语言

环境信息(Environment)

  • OS: [Windows11]
  • Browser: [ all ]
  • OpenSumi Version: [ core/main ]
@zhuzeyu22 zhuzeyu22 added the 🐞 bug Something isn't working label Jul 18, 2023
@erha19
Copy link
Member

erha19 commented Jul 18, 2023

@zhuzeyu22 这里确实应该追加相关按钮提示,可以参考这个效果加一下
image
参考代码见:


组件应该存在默认值,如 “更多”,同时应该接受外部传参,去声明 moreText,如
export const TitleActionList: React.FC<
{
menuId: string | MenuId;
nav: MenuNode[];
more?: MenuNode[];
moreIcon?: string;
className?: string;
iconService?: IMenubarIconService;
} & BaseActionListProps

zhuzeyu22 added a commit to zhuzeyu22/core that referenced this issue Jul 18, 2023
zhuzeyu22 added a commit to zhuzeyu22/core that referenced this issue Jul 18, 2023
zhuzeyu22 added a commit to zhuzeyu22/core that referenced this issue Jul 18, 2023
zhuzeyu22 added a commit to zhuzeyu22/core that referenced this issue Jul 18, 2023
@Ricbet Ricbet closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants