New note page on low zooms #5443
Merged
+154
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
new-note-marker-variable
branch
from
7c8e2f2 to
2a5ae1a
Compare
tomhughes
reviewed
Dec 30, 2024
This function doesn't update any existing marker.
This function adds a marker to notes layer. This controller doesn't need to do anything with markers of existing notes.
We want the new note marker in the same layer with its halo. Also we don't want to put anything in noteLayer because it clears its contents on certain zoom levels.
AntonKhorev
force-pushed
the
new-note-marker-variable
branch
from
2a5ae1a to
927267d
Compare
newHalo() wasn't always creating new halos. It had an event type argument that was checked against drag event. Depending on this check, newHalo() could remove the halo.
AntonKhorev
force-pushed
the
new-note-marker-variable
branch
from
927267d to
2353401
Compare
This ensures that marker is always added/removed together with its halo.
It was also called from noteCreated() but that triggered page.unload() via OSM.router.route().
Same reasons as in the previous commit.
AntonKhorev
force-pushed
the
new-note-marker-variable
branch
from
2353401 to
fe8a87b
Compare
Note that addNoteButton.hasClass("active") check in page.load is useless because page.unload removes this class.
If not done, it's possible to lose the marker when starting from low zooms.
AntonKhorev
force-pushed
the
new-note-marker-variable
branch
from
fe8a87b to
27aa2ed
Compare
tomhughes
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
/note/newwhile your zoom is too low as described in low zoom URLs for adding a note handled badly #1291/note/new,show a warning message and disable the submit button.
Fixes #1291 and another bug: note marker was disappearing together with notes layer when visible area became too large.