Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resourceful routes for received/issued blocks #5440

Merged
merged 6 commits into from
Dec 30, 2024

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Dec 24, 2024

This creates :issued_blocks and :received_blocks resources for users. :revoke_all action is changed to deleting received blocks.

Copy link

1 Warning
⚠️ Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?

Generated by 🚫 Danger

@tomhughes
Copy link
Member

Using the edit action as the revoke all view is a bit weird but I guess if we ever want to more general edit we can change the title of that page and the link to it and then just have revoke as one thing you can do from the edit page.

Other than that this looks good to me, thanks.

@tomhughes tomhughes merged commit 7565f5a into openstreetmap:master Dec 30, 2024
22 checks passed
@AntonKhorev AntonKhorev deleted the user-blocks-resources branch December 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants