Add social profile links #5439
Add social profile links #5439
Conversation
nertc
force-pushed
the
issue_2245_add_social_links
branch
from
471cbf6 to
46f7da6
Compare
nertc
force-pushed
the
issue_2245_add_social_links
branch
from
46f7da6 to
55c89e6
Compare
|
Do we need another set of icons in addition to |
|
|
||
| def parsed | ||
| URL_PATTERNS.each do |platform, pattern| | ||
| username = url.match(pattern) |
There was a problem hiding this comment.
It's not a username, is it?
There was a problem hiding this comment.
It's a user's name shown in the URL of some websites' profile page (for example, in the https://github.com/nertc nertc is a username)
There was a problem hiding this comment.
MatchData object is not a username.
| <% end %> | ||
| </div> | ||
|
|
||
| <%= link_to "+", "#", :id => "add-social-link", :class => "btn btn-outline-primary" %> |
There was a problem hiding this comment.
Why is it a link and not a button?
Why adding is "+" but removing is "Remove"?
There was a problem hiding this comment.
I had a different logic that needed a link, as I changed logic, I agree with you, I'll change it to button.
My idea was that + sign doesn't require any additional icons and is intuitive, while Remove needs trash icon to be intuitive (- sign doesn't always mean removal and sometimes it may be ambiguous). But I agree with you, maybe it's better to be consistent in this too. Which one do you think is better, to change + sign to Add (which will be much easier and less-code solution) or to change Remove to trash icon (which may be nicer in terms of UI, but will require trash icon and, therefore, more code)?
| `); | ||
|
|
||
| socialLinkForm.find("button").click(function () { | ||
| $(this).parent().remove(); |
There was a problem hiding this comment.
I press this button, this removes the link, and I'd think it's saved. But actually not, failing the validation will resurrect the link.
| class SocialLink < ApplicationRecord | ||
| belongs_to :user | ||
|
|
||
| validates :url, :presence => true, :format => { :with => URI::DEFAULT_PARSER.make_regexp(%w[http https]), :message => I18n.t("profiles.edit.social_links.http_parse_error") } |
There was a problem hiding this comment.
This doesn't check if url starts with http://.
And if you also disable CSP:
|
When I'm making a site for myself and there's this kind of UI with Add buttons adding an input and Remove buttons next to added inputs, I don't bother doing it. I just put a |
This PR addresses "Please make contact information fields, how to contact the user, email address, telegrams, various social networks https://www.openstreetmap.org" issue mentioned in the #2245
Description
This PR adds:
Currently parser parses these websites and adds their icons which are taken from Bootstrap-Icons:
Discord, Line, Skype and Slack doesn't show username in the URL. To avoid showing some Id numbers on the profile page, for these cases instead of the Id only the name of the application is shown.
Applications other than those mentioned in the list show their URL on the profile page and have general web icon (globe icon).
If there is an idea that some of them should be removed or others should be added, feel free to share recommendations.
Parser was done in the Ruby to avoid adding more JS client-side logic to the website. If it is preferable, it can be moved to JS.
How has this been tested?
There are validation and functional tests written to test the functionality. In addition to this, different kind of manual testing was done to ensure that all the icons, errors, fields and etc. were displayed correctly.
Screenshots
Logged out:
Logged in:
Edit Profile page:
