New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace show and index abilities with read ability #5422

Merged

tomhughes merged 1 commit into openstreetmap:master from AntonKhorev:read-ability

Dec 20, 2024

Collaborator

AntonKhorev commented Dec 20, 2024 •

edited

Loading

Use CanCanCan's :read alias instead of :index and :show abilities. Similar to #5164 and #5185.

I made a couple of exceptions:

Note has :show and :index abilities in different branches. I kept them. It's probably because one is on map layout, another one is on site layout and we try to avoid redirecting to the 403 page from map layout.
I kept :index for :site. :index here means an entirely different thing.


          Replace show and index abilities with read ability

b95a8d0

Member

tomhughes commented Dec 20, 2024

Looks good to me, thanks.

tomhughes merged commit 92242f5 into openstreetmap:master

22 checks passed

AntonKhorev deleted the read-ability branch

December 20, 2024 11:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet