Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve note testing and text handling #5419

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

AntonKhorev
Copy link
Collaborator

  • Add test that would have failed in Bogus comment is added when a note is reopened #5359.
  • Change the code that selects the text input from $("textarea") to content.find("textarea"). This should stop the html share code from getting posted to notes, although I couldn't reproduce that happening like @SomeoneElseOSM reported it yesterday. When you press Hide the textarea inside the left sidebar exists and is the first one on the page, I don't know how that other textarea got selected instead.

@tomhughes
Copy link
Member

Looks good to me, thanks.

@tomhughes tomhughes merged commit 5ce51e9 into openstreetmap:master Dec 19, 2024
22 checks passed
@AntonKhorev AntonKhorev deleted the fix-note-text branch December 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants