Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'canDownloadImage' layer option #5416

Merged

Conversation

AntonKhorev
Copy link
Collaborator

Follows #5388. Removes hardcoded layer id checks in Share > Image, except for one special mapnik check.

If a layer that can't be downloaded is selected, the message shows a list of available layers:

Before:
image

After:
image

@AntonKhorev AntonKhorev force-pushed the map-layer-can-download-image branch from d74decf to 2765201 Compare December 18, 2024 17:05
@AntonKhorev AntonKhorev force-pushed the map-layer-can-download-image branch from 2765201 to 2ba8547 Compare December 19, 2024 15:59
Copy link
Member

@tomhughes tomhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks much better now, thanks.

@tomhughes tomhughes merged commit 0434bee into openstreetmap:master Dec 19, 2024
22 checks passed
@AntonKhorev AntonKhorev deleted the map-layer-can-download-image branch December 20, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants