Modify the way "Friends" are added #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
reviewed
Oct 15, 2024
tomhughes
reviewed
Oct 15, 2024
kcne
reviewed
Oct 16, 2024
kcne
reviewed
Oct 16, 2024
nertc
force-pushed
the
issues_3310_modify_the_way_friends_are_added
branch
from
e1a1b87 to
8393857
Compare
|
Thank you for the review. This PR was updated according to recommendations. |
nertc
force-pushed
the
issues_3310_modify_the_way_friends_are_added
branch
from
8393857 to
02bede7
Compare
Generated by 🚫 Danger |
|
PR was updated. Now friendship controller and model are refactored to be named as "follow" and also implement standard CRUD architecture using |
AntonKhorev
reviewed
Nov 14, 2024
nertc
force-pushed
the
issues_3310_modify_the_way_friends_are_added
branch
from
02bede7 to
36fba94
Compare
AntonKhorev
reviewed
Jan 2, 2025
AntonKhorev
reviewed
Jan 2, 2025
AntonKhorev
reviewed
Jan 2, 2025
nertc
force-pushed
the
issues_3310_modify_the_way_friends_are_added
branch
2 times, most recently
from
5c9c7b8 to
a153faf
Compare
AntonKhorev
reviewed
Jan 10, 2025
AntonKhorev
reviewed
Jan 10, 2025
AntonKhorev
reviewed
Jan 10, 2025
nertc
force-pushed
the
issues_3310_modify_the_way_friends_are_added
branch
from
a153faf to
9fcfc1a
Compare
nertc
force-pushed
the
issues_3310_modify_the_way_friends_are_added
branch
from
9fcfc1a to
be11f20
Compare
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses "Modify the way 'Friends' are added" issue mentioned in #3310
This PR replaces all occurrences of "friends" to "followers", including texts, tests and URLs.
This PR was not broken down to smaller pieces to maintain consistency and avoid different names of the same functionality.