Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared pagination: label instead of i18n key as parameter #5174

Closed
wants to merge 1 commit into from

Conversation

mmd-osm
Copy link
Contributor

@mmd-osm mmd-osm commented Sep 8, 2024

Pass translated label to shared pagination instead of i18n key.

This reduces the number of reported issues when running bundle exec i18n-tasks unused

Apparently, there are lots of pending PR out there that would conflict with this change: #4734, #4733, #4729, #4710
What's the status here? Which one of these alternatives will make it in the end?

@AntonKhorev
Copy link
Collaborator

In #4734 etc I need four different labels, so instead I pass the scope and append .newest / .newer / .older / .oldest. And what if I need even more strings, for example, a different tooltip string for each button? Do you propose to pass all of them separately?

@mmd-osm
Copy link
Contributor Author

mmd-osm commented Sep 9, 2024

4 strings might be still ok, for more strings it would be good to have an alternative approach.

@AntonKhorev
Copy link
Collaborator

If the goal is to make i18n-tasks unused stop complaining we can create a scope just for pagination strings and tell i18n-tasks to ignore it.

@mmd-osm
Copy link
Contributor Author

mmd-osm commented Sep 9, 2024

Yes, I think that would be the better approach. Passing lots of strings doesn’t scale well.

@mmd-osm mmd-osm marked this pull request as draft September 9, 2024 16:05
@mmd-osm mmd-osm closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants