Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set layer button size relative to font size #5067

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

AntonKhorev
Copy link
Collaborator

Probably fixes #5066.

Before:

150% zoom / 150% text-only zoom:
image image

After:

150% zoom / 150% text-only zoom:
image image

Lets buttons become larger if font-only zoom is used. This should help with layer name labels not fitting.
@AntonKhorev AntonKhorev changed the title Set layer button size in rems Set layer button size relative to font size Aug 12, 2024
Copy link
Contributor

@nertc nertc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works perfectly, it fixes the issue (it works with different resolutions and font sizes), and code is written in a good way.

@tomhughes
Copy link
Member

Looks good to me, thanks.

@tomhughes tomhughes merged commit 7cd7db5 into openstreetmap:master Aug 13, 2024
20 checks passed
@AntonKhorev AntonKhorev deleted the layer-button-height-rem branch August 14, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Tracestrack Topo" name too long for space given
3 participants