Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set og:description meta tag to diary entry description #5056

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

AntonKhorev
Copy link
Collaborator

Uses the first paragraph with text truncated to 500 characters as an OpenGraph description on diary entry pages. Uses the default text on other pages or if no paragraph with text is found.

Fixes #1361

Copy link
Collaborator

@gravitystorm gravitystorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small tweak here, otherwise looks good to me.

Copy link
Contributor

@kcne kcne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful and a great piece of work. The code seems fine as far as I can tell. This update also aligns well with PR addressing social sharing functionality #4985.

@gravitystorm gravitystorm merged commit 735a5cf into openstreetmap:master Aug 14, 2024
20 checks passed
@gravitystorm
Copy link
Collaborator

Merged, thanks!

@AntonKhorev AntonKhorev deleted the diary-og-description branch August 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diary posts should populate Open Graph tags for social sharing
3 participants