-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move continue auth/start mapping button to appear fixed to the bottom of the welcome page #4947
base: master
Are you sure you want to change the base?
Conversation
The obvious risk here is that it encourages people to hit the button and get going without reading the page first. |
Just to give more context to the public - Map builder started experimenting with SSO flow and we notice that "only" 35% of users finishes sign-up procedure (@pietervdvn can comment too, if you have numbers for MapComplete). This PR tries to improve sign-up rate for both users coming to osm.org and coming from third-party apps. There is not much to say that isn't already said in #4246. In that solution, we thought it would be good to skip "welcome" page (or shorten it) as it presents partially unnecessary information for users coming from other apps and move part of its content for async consumption (e-mail) and move education bits to editors. If we don't want to go with that solution, it would be at least good to have this button pinned. We tried to do pinning for both buttons ("Start mapping" and "Continue auth") as per @tomhughes comment in #4246 (comment).
I guess if people do not want to read page, they will just scroll to the bottom even today (if they figure out there is something at the bottom!). Those who want to read it - can read it, this change doesn't block that. Most important parts IMHO ("What's on the map" and about not copying from other maps) are prominent and visible even without scrolling. At the end of day - this is just a standard visual clue to signify to users that there is something to click/proceed. P.S. If you think it is mandatory for users to read it, we can disable button until users scroll to the bottom (as some legal text require user to do), but I hope we are not going there (and whole solution would look like "design by committee" to me😄). P.P.S. I can go to philosophical rent about ad tech/social network companies and web trends and how they used "engagement" metrics and stole our attention span, so that now every wall of text is insurmountable mountain to pass, and how it affects osm.org, but it is more for diary:) |
I agree that this improves the UX and Flow with IMO minimal negative side effects. I also still think a separate flow for this use case as discussed in the linked issue (that removes this page but preserves the information as part of a follow up email) would be better. However, given the constrains to not do this, this is a good idea. |
@tomhughes With given explanation and @tordans comment, can you reassess this? Otherwise, can you propose alternative approach (which is not status quo) on this? We proposed disabling button until page is scrolled to the bottom, what are your thoughts to that? Or please close PR if you don't want to change anything, it will help us focus on other stuff |
I was kind of leaving this to see if any of the other maintainers had an opinion before considering it again... Any thoughts @gravitystorm or @AntonKhorev? |
If we want something like this we can add a footer to the layout similar to https://github.com/AntonKhorev/openstreetmap-website/tree/x/welcome-sticky-footer |
@AntonKhorev I agree, would you like me to fetch your commits and add them to this PR, or do you prefer to open a new PR for this change? |
@kcne If you want to finish this PR you can use my commits here. |
Something has gone badly wrong - you've just pushed over a hundred commits that look like they been cherry picked from master or something. I think you've managed to make your history diverge somehow. |
bb5e5af
to
7bbe61f
Compare
Forgot to do rebase from master branch. Can you check if everything is okay now? |
Yes it's fixed now. |
The commits here should probably be squashed because they partly undo previous commits. And we have conventions for commit messages like starting with a capital letter. |
dc73c03
to
de2723b
Compare
Squashed commits and renamed according to conventions. If you have any additional ideas how to improve this further please let me know! Thank you. @AntonKhorev |
Pin 'Continue Auth/Start Mapping' button to bottom of page for improved user navigation and simplified OAuth process.
de2723b
to
874f59e
Compare
Move continue auth/start mapping button to appear fixed to the bottom of the welcome page
Objective
To enhance the user experience by pinning the existing "Continue Auth/Start Mapping" button at the bottom of the page. This adjustment is aimed at improving user navigation and simplifying the OAuth process.
Key Points